fix: divider in temperature presets is transparent #1004
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Dominik Willner <th33xitus@gmail.com>
meteyou
approved these changes
Aug 6, 2022
|
LGTM |
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solves the following issue:
For some reason the
v-dividerinside of thev-menuis rendered transparent and you can see the text underneath thev-menuthrough it.Probably due to the case that it is set by Vuetify that way.
The expected behavior though would be, that the background color of the
v-menugets respected. Which, for some reason, is not the case. Presumably this might be a bug with Vuetify?This PR solves the issue with applying a background color to that
v-dividerelement as a workaround.Signed-off-by: Dominik Willner th33xitus@gmail.com